Skip to content

[CDF-28565]🪠 Delete unused data classes - #3216

Merged
doctrino merged 35 commits into
mainfrom
remove-unused-data-classes
Sep 8, 2026
Merged

[CDF-28565]🪠 Delete unused data classes#3216
doctrino merged 35 commits into
mainfrom
remove-unused-data-classes

Conversation

@doctrino

@doctrino doctrino commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Deleting classes that were only used by build v1, clean v1 and deploy v1.

Bump

  • Patch
  • Skip

@gemini-code-assist

gemini-code-assist Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino
doctrino force-pushed the remove-unused-data-classes branch from fc2f3fb to 3dee6a9 Compare September 7, 2026 18:32
@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
43072 36835 86% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/data_classes/init.py 100% 🟢
cognite_toolkit/_cdf_tk/data_classes/_base.py 67% 🟢
cognite_toolkit/_cdf_tk/data_classes/_config_yaml.py 77% 🟢
cognite_toolkit/_cdf_tk/data_classes/_deploy_results.py 72% 🟢
cognite_toolkit/_cdf_tk/validation.py 95% 🟢
TOTAL 82% 🟢

updated for commit: 32a5b33 by action🐍

@codecov

codecov Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.51%. Comparing base (a285039) to head (32a5b33).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...te_toolkit/_cdf_tk/data_classes/_deploy_results.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
+ Coverage   85.03%   85.51%   +0.48%     
==========================================
  Files         466      460       -6     
  Lines       43830    43072     -758     
==========================================
- Hits        37271    36835     -436     
+ Misses       6559     6237     -322
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/data_classes/__init__.py 100.00% <ø> (ø)
cognite_toolkit/_cdf_tk/data_classes/_base.py 66.66% <100.00%> (+13.00%) ⬆️
...gnite_toolkit/_cdf_tk/data_classes/_config_yaml.py 77.38% <100.00%> (+13.99%) ⬆️
cognite_toolkit/_cdf_tk/validation.py 94.73% <ø> (+9.88%) ⬆️
...te_toolkit/_cdf_tk/data_classes/_deploy_results.py 72.41% <50.00%> (+15.86%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino
doctrino marked this pull request as ready for review September 7, 2026 18:49
@doctrino
doctrino requested review from a team as code owners September 7, 2026 18:49
@doctrino doctrino changed the title [CDF-28565]🪠 Delete unused issues [CDF-28565]🪠 Delete unused data classes Sep 7, 2026
@doctrino
doctrino force-pushed the remove-dataCRUD branch 2 times, most recently from bb2d249 to 1ff4b84 Compare September 8, 2026 08:11
ronpal
ronpal previously approved these changes Sep 8, 2026
View reviewed changes
Base automatically changed from remove-dataCRUD to main September 8, 2026 09:02
@doctrino
doctrino dismissed ronpal’s stale review September 8, 2026 09:02

The base branch was changed.

@doctrino
doctrino enabled auto-merge (squash) September 8, 2026 09:02
@doctrino
doctrino requested a review from ronpal September 8, 2026 09:03
@doctrino
doctrino merged commit 2a92dbf into main Sep 8, 2026
13 checks passed
@doctrino
doctrino deleted the remove-unused-data-classes branch September 8, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronpal ronpal ronpal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doctrino @ronpal